Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing BigNumber import (ENG-3326) #682

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Add missing BigNumber import (ENG-3326) #682

merged 1 commit into from
Nov 25, 2023

Conversation

victorkirov
Copy link
Member

🔘 PR Type

What kind of change does this PR introduce?

  • Bugfix

📜 Background

There was a missing import for BigNumber on the send BTC confirmation page.

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@victorkirov victorkirov self-assigned this Nov 25, 2023
@victorkirov victorkirov changed the title Add missing BigNumber import Add missing BigNumber import (ENG-3326) Nov 25, 2023
@github-actions GitHub Actions
Copy link

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/6987645860

@yknl yknl changed the base branch from develop to release/v0.23.2 November 25, 2023 07:07
@yknl yknl merged commit f1b1324 into release/v0.23.2 Nov 25, 2023
2 checks passed
@yknl yknl mentioned this pull request Nov 25, 2023
Merged
15 tasks
@teebszet teebszet deleted the vic/fix/bignumber branch November 26, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yknl yknl yknl approved these changes

@DuskaT021 DuskaT021 DuskaT021 approved these changes

Assignees

@victorkirov victorkirov

Labels
Release 0.23.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@victorkirov @yknl @DuskaT021 @teebszet